Fix "Make Unique" button only working with left mouse click#113740
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Dec 15, 2025
Merged
Fix "Make Unique" button only working with left mouse click#113740Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
arkology
reviewed
Dec 8, 2025
Contributor
arkology
left a comment
arkology
left a comment
There was a problem hiding this comment.
I was just in process of making a patch...
Your solution will break making recursive unique.
Most likely the right fix is:
void EditorResourcePicker::_on_unique_button_pressed() {
if (Input::get_singleton()->is_mouse_button_pressed(MouseButton::LEFT)) {
_edit_menu_cbk(OBJ_MENU_MAKE_UNIQUE);
} else if (Input::get_singleton()->is_mouse_button_pressed(MouseButton::RIGHT) && _is_uniqueness_enabled(true)) {
_edit_menu_cbk(OBJ_MENU_MAKE_UNIQUE_RECURSIVE);
}
}
ayanchavand
force-pushed
the
fix/left-mouse-make-unique
branch
from
c9820d1 to
20c183b
Compare
Contributor
Author
|
Sorry about that! I am quite new to engine contribution. I have added your fix |
Contributor
|
Please note that I did not test this fix, make sure it works correctly :) |
Contributor
Author
|
I checked, it works. |
akien-mga
changed the title
KoBeWi
approved these changes
Dec 15, 2025
Member
|
That's not a regression btw, it's a bug in the new functionality. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113738
Removed the Mouse button mask for right so the button only works for left click as suggested by the tooltip