Codestyle: Remove unused private variables in godot/editor#113706
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Dec 9, 2025
Merged
Codestyle: Remove unused private variables in godot/editor#113706akien-mga merged 1 commit intogodotengine:masterfrom
godot/editor#113706akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
KoBeWi
approved these changes
Dec 7, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes unused private variables in the
godot/editorfolder that were declared in.hfiles and not in the corresponding.cppfile. As a conservative estimate it ignored files that had afriend classinside, just in case the variables were mentioned in another file.I didn't attempt to look through the blame to see why each variable was removed, but I believe that if it is no longer referenced, it is better to remove now, and reinstate later if the functionality is desired.