Improve style changed signal in EditorDock#113690
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Dec 15, 2025
Merged
Conversation
KoBeWi
force-pushed
the
take_signal_away_from_user
branch
2 times, most recently
from
64f9210 to
158752e
Compare
kitbdev
approved these changes
Dec 13, 2025
editor/docks/editor_dock.cpp
Outdated
| @@ -93,6 +97,7 @@ void EditorDock::_bind_methods() { | |||
| ADD_PROPERTY(PropertyInfo(Variant::INT, "available_layouts", PROPERTY_HINT_FLAGS, "Vertical:1,Horizontal:2,Floating:3"), "set_available_layouts", "get_available_layouts"); | |||
Contributor
There was a problem hiding this comment.
Unrelated but this should be 1 2 4 since they are flags
KoBeWi
force-pushed
the
take_signal_away_from_user
branch
from
158752e to
0ed400a
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
tab_style_changedsignal from user signal to properly registered internal signal. Also added_emit_changed()method that emits the signal usingSNAME.