@clayjohn

@clayjohn

godot/servers/rendering/renderer_rd/environment/sky.cpp

Lines 1108 to 1118 in 05830df

	if (light_data_dirty) {
	RD::get_singleton()->buffer_update(sky_scene_state.directional_light_buffer, 0, sizeof(SkyDirectionalLightData) * sky_scene_state.max_directional_lights, sky_scene_state.directional_lights);
	SkyDirectionalLightData *temp = sky_scene_state.last_frame_directional_lights;
	sky_scene_state.last_frame_directional_lights = sky_scene_state.directional_lights;
	sky_scene_state.directional_lights = temp;
	sky_scene_state.last_frame_directional_light_count = sky_scene_state.ubo.directional_light_count;
	if (sky) {
	sky->reflection.dirty = true;
	}
	}

godot/servers/rendering/renderer_rd/environment/sky.cpp

Lines 1262 to 1263 in 05830df

	// Update radiance octmap
	if (sky->reflection.dirty && (sky->processing_layer >= max_processing_layer || update_single_frame)) {

It looks like the when the directional light buffer is updated, so is the radiance buffer?

Thanks, that's right. But the radiance buffer should only be updated if the directional light buffer is updated and the sky shader is using directional lights. So I think the proper solution will be to change when the radiance is set to dirty

I.e. this:

if (sky) { 
	sky->reflection.dirty = true; 
} 

Should look like:

if (sky && sky->uses_lights) { 
	sky->reflection.dirty = true; 
} 

@clayjohn If you go up a bit, this code is already dependent on:

If sun scatter is enabled, lights appear in the sky even if the user's shader does not use any LIGHTX_* built-ins (uses_lights will be false). Is this not the same reason for using SKY_MODE_INCREMENTAL when uses_lights == true?

Good point. I was forgetting that sun_scatter is evaluated in the sky shader. In my mind it was only in the scene shader and fog shader. In that case this is the correct fix!

Thanks!