GDScript: Ensure correct caching of cyclic references#113600
GDScript: Ensure correct caching of cyclic references#113600akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
|
confirmed on my end this works for both the MRP in the cyclic references issue and my game 🎉 |
Yeah it's unfortunate that it didn't get approved earlier in the release cycle. But let's give it a try in dev6/beta1 with the regression fixes and see where to take it from there. |
2f1e687 to
ab03978
Compare
|
Thanks! |
Followup to #109345
Requires and includes #113580
Fixes #113588
Explanation:
ResourceLoaderResourceCache#109345). This seems to work fine, theResourceCachecan handle it and we can ensure that fully loaded scripts always have their path set correctly.I retested a lot of MRP's with this PR + #113580
And so far those issues seem to still be fixed with this change:
Note
With the original PR I always had the intention of "fixing forward" as in getting it out and investigating and addressing regressions. I don't think we will be able to make this resource mess work out of the box in a single PR.
What I did not intend was to get this merged so close to release. In fact I suggested giving the original PR a try early in the dev cycle but that never happened.
So if the production team decides for a revert instead of merging my followups that's fine by me.
Just would be nice to give this another try in the next dev cycle if we go with a revert.