Fix bad D3D12 SRV breaking MSAA with OpenXR#113585
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Dec 5, 2025
Merged
Fix bad D3D12 SRV breaking MSAA with OpenXR#113585akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
Contributor
|
cc @clayjohn |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found MSAA+D3D12+OpenXR was broken. The first error I see is this when I try:
and then it spews errors because the device is lost (0x887a0005=DXGI_ERROR_DEVICE_REMOVED). I used
--gpu-validation --gpu-abortwhich showed that the original error was here inRenderingDeviceDriverD3D12::uniform_set_create:The validation layer said:
This was a bit misleading because the ArraySize was set correctly in the Texture2DMSArray section, but it was looking at the Texture2DArray section (which is uninitialized) because the ViewDimension was set wrong. So thankfully this was a 2 letter fix.