[Unix] Remove leading .. from absolute paths and apply simplify_path to Unix current directory path.#113575
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Dec 18, 2025
Merged
Conversation
AThousandShips
added
the
cherrypick:4.5
adamscott
reviewed
Dec 4, 2025
Member
Author
|
Failed test seems to be an abuse of path, it's trying to load |
…th` to Unix current directory path.
Member
Author
|
Since it might be used by GLTF importer, I have added a check to allow |
akien-mga
removed
the
cherrypick:4.5
akien-mga
approved these changes
Dec 18, 2025
Member
akien-mga
left a comment
akien-mga
left a comment
There was a problem hiding this comment.
The bug has already been fixed by an alternative approach, so this is not urgent.
But let's give it a spin for 4.7-dev so that we have enough time to solve any potential side effects of changing simplify_path.
Member
|
Well it seems I merged this anyway by mistake in my last batch... It's going to be in 4.6-beta2, so let's see if any issue is reported or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
..from absolute paths insimplify_path.simplify_pathin the Unixfix_path(same is already done on Windows).Fixes #113497