X Tutup
Skip to content

Enable scroll hints for several parts of the editor#113574

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
YeldhamDev:take_the_hint
Dec 9, 2025
Merged

Enable scroll hints for several parts of the editor#113574
akien-mga merged 1 commit intogodotengine:masterfrom
YeldhamDev:take_the_hint

Conversation

@YeldhamDev
Copy link
Member

@YeldhamDev YeldhamDev commented Dec 4, 2025 •
edited
Loading

Tackles godotengine/godot-proposals#13581 and #112454.

  • Enable scroll hints for several areas in the editor where it made sense and looked appropriate.
  • Only present in the modern theme.
  • Add scroll hints for ItemList, necessary for this PR to be made.
  • Fix some issues with scroll hints in Tree.
  • Remove the scrollbar hack in the animation player editor, putting it back in its default place. Instead, it adds a gap in the timeline control when the vertical scrollbar is visible while in RTL mode.
Screenshots Screenshot_20251203_194509 Screenshot_20251203_194358 Screenshot_20251204_083822

@YeldhamDev YeldhamDev added this to the 4.6 milestone Dec 4, 2025
@YeldhamDev YeldhamDev requested review from a team as code owners December 4, 2025 17:07
@YeldhamDev YeldhamDev added the bug label Dec 4, 2025
@YeldhamDev YeldhamDev requested review from a team as code owners December 4, 2025 17:07
@YeldhamDev YeldhamDev requested a review from a team December 4, 2025 17:07
@YeldhamDev YeldhamDev requested review from a team as code owners December 4, 2025 17:07
@YeldhamDev YeldhamDev requested a review from a team as a code owner December 4, 2025 17:07
passivestar
passivestar approved these changes Dec 6, 2025
View reviewed changes
Copy link
Contributor

@passivestar passivestar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks great

For docks it's a great addition to separate scroll areas from the topbars, in search-related popup dialogs like command palette and quick search the bottom separation shadow may draw a bit too much attention to itself, but I think quick search popups shouldn't even have bottom buttons in the first place to need that separation (see godotengine/godot-proposals#13744) so I think it's fine for now

@KoBeWi
Copy link
Member

KoBeWi commented Dec 6, 2025 •
edited
Loading

The relationship lines in FileSystem don't reach the bottom:
image

EDIT:
Also it would be nice to add hints to CreateDialog too. It seems to be missing in the changes.

EDIT:
Also ResourcePreloader xd
image

KoBeWi
KoBeWi reviewed Dec 6, 2025
View reviewed changes
@YeldhamDev
Copy link
Member Author

YeldhamDev commented Dec 8, 2025 •
edited
Loading

@KoBeWi I can't really add it to the create dialog because the hints wont be able to touch the left border due to the lists in the way.

Also, is there a way for an EditorDock to know if it was placed in a dock or in the bottom panel? I need this information to properly set the hints for the ResourceLoader.

The relationship lines in FileSystem don't reach the bottom

This doesn't seem related to the PR, but instead a bug in Tree.

@KoBeWi
Copy link
Member

KoBeWi commented Dec 9, 2025

Also, is there a way for an EditorDock to know if it was placed in a dock or in the bottom panel?

Override update_layout(). DOCK_LAYOUT_HORIZONTAL is for bottom panel.

@YeldhamDev YeldhamDev requested a review from a team as a code owner December 9, 2025 13:55
@YeldhamDev
Copy link
Member Author

YeldhamDev commented Dec 9, 2025

@KoBeWi Changes made.

@akien-mga akien-mga merged commit d09a3d8 into godotengine:master Dec 9, 2025
20 checks passed
@akien-mga
Copy link
Member

akien-mga commented Dec 9, 2025

Thanks!

This was referenced Dec 9, 2025
Closed
Closed
@YeldhamDev YeldhamDev deleted the take_the_hint branch December 9, 2025 18:37
This was referenced Dec 10, 2025
Merged
Merged
@AThousandShips AThousandShips mentioned this pull request Dec 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

@passivestar passivestar passivestar approved these changes

Assignees

No one assigned

Labels

bug enhancement topic:editor topic:gui

Projects

None yet

Milestone

4.6

Development

Successfully merging this pull request may close these issues.

4 participants

@YeldhamDev @KoBeWi @akien-mga @passivestar
X Tutup