Fix memory management for ColorPalette in save file dialog#113573
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Dec 5, 2025
Merged
Fix memory management for ColorPalette in save file dialog#113573akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
KoBeWi
reviewed
Dec 4, 2025
KoBeWi
approved these changes
Dec 4, 2025
Member
|
The commits need to be squashed. |
MattiaZir
force-pushed
the
fix-color-picker-crash
branch
from
23fc647 to
7d77641
Compare
MattiaZir
force-pushed
the
fix-color-picker-crash
branch
from
7d77641 to
bf85f96
Compare
Contributor
Author
|
Done, thank you again! |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
Ref<T>instead of creating a raw pointer seems to have fixed #113556.