Fix signal order for directory selection in file_dialog#113564
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Dec 5, 2025
Merged
Fix signal order for directory selection in file_dialog#113564akien-mga merged 1 commit intogodotengine:masterfrom
file_dialog#113564akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
AThousandShips
changed the title
file_dialog
MattiaZir
changed the title
file_dialog
MattiaZir
changed the title
file_dialog
Contributor
Author
|
@AThousandShips Sorry for unfixing the title, didn't expect you to be this fast! |
This comment was marked as resolved.
This comment was marked as resolved.
MattiaZir
force-pushed
the
fix-project-import-error-parent-child
branch
from
9608638 to
0e02899
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
The same needs to be applied to other signals: godot/scene/gui/file_dialog.cpp Lines 375 to 376 in 78d9194 godot/scene/gui/file_dialog.cpp Lines 416 to 417 in 78d9194 godot/scene/gui/file_dialog.cpp Lines 427 to 428 in 78d9194 |
Contributor
Author
|
Thank you for the tip |
KoBeWi
approved these changes
Dec 4, 2025
Member
|
Looks good! Could you squash the commits? See PR workflow for instructions. |
MattiaZir
force-pushed
the
fix-project-import-error-parent-child
branch
from
443a5eb to
98ccfb0
Compare
Contributor
Author
|
Thank you, did I squash it correctly? |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like it's a simple fix, but I would like your opinion since the file_dialog file is pretty important.
It should fix #113487