X Tutup
Skip to content

Fix profiler cleanup with --test.#113557

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
bruvzg:test_prof_clean
Dec 4, 2025
Merged

Fix profiler cleanup with --test.#113557
akien-mga merged 1 commit intogodotengine:masterfrom
bruvzg:test_prof_clean

Conversation

@bruvzg
Copy link
Member

@bruvzg bruvzg commented Dec 4, 2025

Fixes crash on exit when using --test with enabled Tracy profiler. Test overrides main and cleanup was never called.

[doctest] test cases:   1251 |   1251 passed | 0 failed | 3 skipped
[doctest] assertions: 416569 | 416569 passed | 0 failed |
[doctest] Status: SUCCESS!
ERROR: Pages in use exist at exit in PagedAllocator: N13TracyInternal16StringInternDataE
   at: ~PagedAllocator (core/templates/paged_allocator.h:169)
libc++abi: terminating due to uncaught exception of type std::__1::system_error: recursive_mutex lock failed: Invalid argument

@bruvzg bruvzg added this to the 4.6 milestone Dec 4, 2025
@bruvzg bruvzg requested a review from a team as a code owner December 4, 2025 12:21
Ivorforce
Ivorforce approved these changes Dec 4, 2025
View reviewed changes
Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks!

@akien-mga akien-mga merged commit 78d9194 into godotengine:master Dec 4, 2025
20 checks passed
@akien-mga
Copy link
Member

akien-mga commented Dec 4, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ivorforce Ivorforce Ivorforce approved these changes

Assignees

No one assigned

Labels

bug topic:core topic:tests

Projects

None yet

Milestone

4.6

Development

Successfully merging this pull request may close these issues.

3 participants

@bruvzg @akien-mga @Ivorforce
X Tutup