EmbeddedProcess: Fix invalid deferred call#113407
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Dec 2, 2025
Merged
EmbeddedProcess: Fix invalid deferred call#113407akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
`Window::grab_focus` does not take any argument.
AThousandShips
approved these changes
Dec 1, 2025
Member
AThousandShips
left a comment
AThousandShips
left a comment
There was a problem hiding this comment.
Did a quick search and this is the only place with Window::grab_focus
akien-mga
approved these changes
Dec 1, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113318.
Follow-up to #110250.
Window::grab_focusdoes not take any argument.Looks like this was an innocent find and replace issue, it happens :D
Note: as per #113318 (comment) , I'm not sure if we should rely so much on calling
grab_focus, as it's not necessarily effective (e.g. sway XWayland). I haven't done a full research on this though so TIWAGOS.That said, this fixes the immediate issue of an error spam.