Fix MovieWriter checking wrong directory for disk space#113398
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Dec 2, 2025
Merged
Fix MovieWriter checking wrong directory for disk space#113398akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
MovieWriter was using get_basename() which strips the file extension but keeps the filename, resulting in checking the current working directory instead of the target output directory. Changed to use get_base_dir() to properly extract the directory path where the movie file will actually be written. Fixes godotengine#113391
AThousandShips
added
the
cherrypick:4.5
akien-mga
approved these changes
Dec 1, 2025
Member
|
Thanks! |
Member
|
Note that this did not fix the issue. The MRP script from #113391 still warns incorrectly. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113391
MovieWriter was incorrectly checking disk space on the current working directory instead of the target output directory specified in
--write-movie.Changes
Changed
get_basename()toget_base_dir()inmovie_writer.cpp:117to properly extract the directory path where the movie file will be written.Before:
get_basename()on/path/to/output.avi→/path/to/output(not a valid directory)dir->open()would open the current working directoryAfter:
get_base_dir()on/path/to/output.avi→/path/to(correct directory)dir->open()opens the actual target directoryImpact