X Tutup
Skip to content

Fix crash when capturing ObjectDB snapshot#113395

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
mihe:objectdb-snapshot-crash
Dec 1, 2025
Merged

Fix crash when capturing ObjectDB snapshot#113395
akien-mga merged 1 commit intogodotengine:masterfrom
mihe:objectdb-snapshot-crash

Conversation

@mihe
Copy link
Contributor

@mihe mihe commented Dec 1, 2025

This fixes the crash mentioned here.

SceneDebuggerObject::_parse_script_properties can be called with a p_instance that's nullptr, leading to a crash when p_instance is dereferenced to invoke get_property_list, as introduced in #111622.

} else if (Script *s = Object::cast_to<Script>(p_obj)) {
// Add script constants (no instance).
_parse_script_properties(s, nullptr);
}

List<PropertyInfo> pinfo;
p_instance->get_property_list(&pinfo);

@akien-mga akien-mga added regression cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Dec 1, 2025
@akien-mga akien-mga merged commit f5918a9 into godotengine:master Dec 1, 2025
20 checks passed
@mihe mihe deleted the objectdb-snapshot-crash branch December 1, 2025 14:19
@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup