Fix TextEdit does not auto scroll properly on certain vertical sizes#113390
Conversation
|
I believe rounding is the correct behavior as it allows for line-perfect scrolling? I think a different approach will be necessary |
Can you explain about rounding in more detail I might be able to fix it . |
|
Rounding was added in #73502 |
AThousandShips
changed the title
TextEdit does not auto scroll properly on certain vertical sizes
AThousandShips
added
the
cherrypick:4.5
|
@bruvzg and @sockeye-d now it is fixed with range of the scrollbar, I think this was that you guys were expecting ? Look at the third video from top |
|
I think some of the tests are failing due to the new logic for the adjustment of the scrollbar |
|
@bruvzg if you need any other changes don't hesitate to ping me |
You will need to adjust the tests to account for these changes, or the changes need to be adjusted to not cause the tests to fail, the tests failing would indicate that this breaks some expected behavior though |
bruvzg
left a comment
bruvzg
left a comment
There was a problem hiding this comment.
Seems to be working as expected.
Please squash the commits, see The interactive rebase.
X1Vi
force-pushed
the
text-edit-does-not-auto-scroll-113290
branch
from
7294820 to
bfaa6e2
Compare
fix: now the scrollbar also should work within the range it is provided adjusted the tests according to the new scrollbar functinality attempted to fix testcases for scrollbar
X1Vi
force-pushed
the
text-edit-does-not-auto-scroll-113290
branch
from
bfaa6e2 to
442c117
Compare
|
@bruvzg I think its done I mean the squashing now there is only one commit for everything. |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
akien-mga
removed
the
cherrypick:4.5
5 participants
Closes #113290
This issue fixes the text edit that it doesn't scroll all the way to the bottom under certain sizes.
I am attaching some examples that I used to reproduce and fix the issue.
Unfixed Build
Screencast.from.2025-12-01.15-51-13.webm
Fixed Build
Screencast.from.2025-12-01.15-51-35.webm
Fixed With Scrollbar Range
Screencast.from.2025-12-01.16-43-16.webm