Fix loading old-style translation files#113322
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Dec 3, 2025
Merged
Conversation
timothyqiu
reviewed
Nov 29, 2025
Member
timothyqiu
left a comment
timothyqiu
left a comment
There was a problem hiding this comment.
I was a bit surprised because _get_messages() has always stored StringName in the Dictionary to be saved.
However, it turns out that StringName keys were converted to Strings when saving prior to 4.4 (see #70096). So this makes sense.
Contributor
Author
|
@timothyqiu can you approve this? |
timothyqiu
approved these changes
Dec 3, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes regression introduced in #108862 .
Versions of Godot prior to current had unoptimized Translation files stored with their messages as Strings, rather than StringNames.
As a result of #108862 's changes, the keys for unoptimized translations fail to load. This fixes it.
cc @timothyqiu