X Tutup
Skip to content

Improvements to ResourcePreloader editor#113257

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
KoBeWi:the_most_important_dock
Dec 3, 2025
Merged

Improvements to ResourcePreloader editor#113257
Repiteo merged 1 commit intogodotengine:masterfrom
KoBeWi:the_most_important_dock

Conversation

@KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Nov 27, 2025

Part of #113024 and #104574 + some minor cleanup.

btw this probably the bottom dock most suited for vertical layout 🤔
image
Literally no layout changes and it looks like it was there from the beginning.

@KoBeWi KoBeWi added this to the 4.x milestone Nov 27, 2025
@KoBeWi KoBeWi requested a review from a team November 27, 2025 22:49
@Mickeon
Copy link
Member

Mickeon commented Nov 27, 2025

btw this probably the bottom dock most suited for vertical layout

Counterpoint, MultiplayerSynchronizer.

Copy link
Member

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my lord this code is so old.

Copy link
Contributor

@lodetrick lodetrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docks look good otherwise!

@KoBeWi
Copy link
Member Author

KoBeWi commented Nov 28, 2025

Counterpoint, MultiplayerSynchronizer.

Yeah, sure xd

image

That's its minimum width btw.

@KoBeWi KoBeWi force-pushed the the_most_important_dock branch from 07fe855 to e6c1842 Compare November 28, 2025 13:57
@KoBeWi KoBeWi force-pushed the the_most_important_dock branch from e6c1842 to 3fcf980 Compare November 28, 2025 14:52
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected. Code looks good to me.

@akien-mga akien-mga modified the milestones: 4.x, 4.6 Dec 2, 2025
@Repiteo Repiteo merged commit cd7cff8 into godotengine:master Dec 3, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 3, 2025

Thanks!

@KoBeWi KoBeWi deleted the the_most_important_dock branch December 3, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

X Tutup