Fix stale error highlighting when navigating script history#113246
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Dec 17, 2025
Merged
Fix stale error highlighting when navigating script history#113246Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
channesl
force-pushed
the
history-error
branch
from
060b685 to
7504b5c
Compare
AThousandShips
added
the
cherrypick:4.5
|
I can confirm, that this fixes my issue #113147 |
kitbdev
approved these changes
Dec 16, 2025
Contributor
kitbdev
left a comment
kitbdev
left a comment
There was a problem hiding this comment.
Makes sense, fixes the issue.
Contributor
|
Thanks! Congratulations on your first merged contribution! 🎉 |
Contributor
Author
|
Thank you very much! |
Member
|
Cherry-picked for 4.5.2. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #113147
This PR fixes an issue where scripts were not being re-validated when navigating through the editor history. This caused error highlights to persist even after the underlying issue was resolved in another file.
I added a validate() call in ScriptEditor::_update_history_pos to ensure the script is re-analyzed upon history navigation, consistent with the behavior when switching tabs manually in ScriptEditor::_go_to_tab.