Make Variant::get_type_by_name HashMap initialization thread-safe#113211
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Dec 2, 2025
Merged
Make Variant::get_type_by_name HashMap initialization thread-safe#113211akien-mga merged 1 commit intogodotengine:masterfrom
Variant::get_type_by_name HashMap initialization thread-safe#113211akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
Updated Variant::get_type_by_name to call separate function for static HashMap initialization, which includes adding the initial key/value pairs.
Ivorforce
approved these changes
Nov 26, 2025
Member
Ivorforce
left a comment
Ivorforce
left a comment
There was a problem hiding this comment.
Both the issue and the fix make sense to me.
For reference, the keyword is C++11 thread-safe static initialization (e.g. listed here).
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
Variant::get_type_by_nameto call separate function for staticHashMapinitialization, which includes adding the initial key/value pairs.Fixes #113210