Add better clarification for accelerator support on Popup Menu#113197
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Dec 1, 2025
Merged
Add better clarification for accelerator support on Popup Menu#113197akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
Member
|
The parentheses at the end of the sentence imply that both pressing an item and activating an accelerator cause the signal to be emitted. |
CrayolaEater
force-pushed
the
pop-up-menu-doc-update
branch
from
e49b508 to
96dd082
Compare
Contributor
Author
I've changed the phrasing. |
Mickeon
reviewed
Nov 27, 2025
CrayolaEater
force-pushed
the
pop-up-menu-doc-update
branch
from
96dd082 to
6b7ec99
Compare
Mickeon
approved these changes
Nov 27, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #112862 (comment)