Fix empty 2D skeleton modification keeps printing error messages#113176
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Dec 1, 2025
Merged
Fix empty 2D skeleton modification keeps printing error messages#113176akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
xuhuisheng
force-pushed
the
dev/ske-mod-error
branch
from
bbab91a to
37a6043
Compare
Member
|
@AThousandShips We probably want to add 2d animation to the animation team as a github repo codeowner. |
AThousandShips
changed the title
fire
changed the title
fire
changed the title
lyuma
approved these changes
Dec 1, 2025
Contributor
lyuma
left a comment
lyuma
left a comment
There was a problem hiding this comment.
Looks safe. Only affects editor, and seems reasonable to early-return if a bone is < 0.
lyuma
moved this from Ready for review
to Approved, Waiting for Production
in Animation Team Issue Triage
akien-mga
added
the
cherrypick:4.5
github-project-automation
bot
moved this from Approved, Waiting for Production
to Done
in Animation Team Issue Triage
Member
|
Thanks! |
Member
|
Cherry-picked for 4.5.2. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description
When we create an empty skeleton modification, editor will try to call
_draw_editor_gizmo()every idle frame, but forget to consider whetherbone_idxis valid.Solution
Check
bone_idxbefore callingget_bone()can prevent printing error message in every frame.