X Tutup
Skip to content

Update dock tabs on setting change#113167

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
KoBeWi:so_anyway
Nov 26, 2025
Merged

Update dock tabs on setting change#113167
akien-mga merged 1 commit intogodotengine:masterfrom
KoBeWi:so_anyway

Conversation

@KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Nov 25, 2025

Fixes regression from #113065
The PR removed a call to update tabs, because the editor does it in _update_theme() and I wrongly though that it happens when the style setting is changed. It doesn't, only Output dock was updating, because it likes to update a lot.

@KoBeWi KoBeWi added this to the 4.6 milestone Nov 25, 2025
@KoBeWi KoBeWi requested a review from a team November 25, 2025 22:09
Copy link
Member

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on prior comments but I have not tested this myself

@akien-mga akien-mga merged commit c260a17 into godotengine:master Nov 26, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the so_anyway branch November 26, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup