Fix SplitContainer crash on change type#113164
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Nov 26, 2025
Merged
Conversation
akien-mga
approved these changes
Nov 25, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SplitContainertoH/VSplitContainercrashes the editor #113158The crash was happening because
_update_draggersexpects to never be called if there is 0 or 1 valid children, but it is deferred so it can be.There is also errors printed about removing children that aren't children, so I added a check for that.
It looks like replacing nodes doesn't delete their internal children, but it does unparent them. I'm not sure if that behavior is correct, but I'll leave it to a future PR.