Add back I/O error-handling to FileAccessPack constructor#113150
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 25, 2025
Merged
Add back I/O error-handling to FileAccessPack constructor#113150Repiteo merged 1 commit intogodotengine:masterfrom
FileAccessPack constructor#113150Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
akien-mga
reviewed
Nov 25, 2025
mihe
force-pushed
the
file-access-pack-errors
branch
from
ab35c1e to
985a5e9
Compare
bruvzg
approved these changes
Nov 25, 2025
Member
bruvzg
left a comment
bruvzg
left a comment
There was a problem hiding this comment.
Change make sense, this should not happen, but I guess can be possible if PCK was deleted (or become unreadable in some other why) while the process is running.
Contributor
Author
Agreed. I'm looking into a bug right now that might possibly be forcing this error in some weird way though. I figured it wouldn't hurt to add this. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an
ERR_FAIL_*check to theFileAccessPackconstructor, to make sure we don't crash in the non-sparse case, by callingFileAccess::seekon a potentially null reference.As far as I can tell, this was inadvertently changed/removed as part of #105984.
I also rephrased the error messages there to log not only the PCK name but also the filename itself.