Wayland: Fix trailing garbage error while using the embedder on Jay#113135
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Nov 27, 2025
Merged
Wayland: Fix trailing garbage error while using the embedder on Jay#113135akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
`send_wayland_message` takes in the number of words, not its byte size. This meant that we were sending quite a bit of out-of-bounds stuff alongside the four arguments required by `xdg_positioner::set_anchor_rect`, which triggered an assertion on Jay. This didn't pop up before because the C wayland server library does not seem to check this, but it's a valid (and useful!) assertion for other server implementations nonetheless. This patch switches to the initializer_list syntax to make the intent clearer.
akien-mga
approved these changes
Nov 27, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
send_wayland_messagetakes in the number of words, not its byte size. This meant that we were sending quite a bit of out-of-bounds stuff alongside the four arguments required byxdg_positioner::set_anchor_rect, which triggered an assertion on Jay.This didn't pop up before because the C wayland server library does not seem to check this, but it's a valid (and useful!) assertion for other server implementations nonetheless.
This patch switches to the initializer_list syntax to make the intent clearer.
Confirmed that fixes the editor on Jay. I'm not sure if there are other instances of this but, judging from the fact that
body_lenbecame unused I think we're in the clear for now :D