Ensure usage of DATA_FORMAT_R32_SFLOAT for depth resolve on Forward+#113130
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 25, 2025
Merged
Ensure usage of DATA_FORMAT_R32_SFLOAT for depth resolve on Forward+#113130Repiteo merged 1 commit intogodotengine:masterfrom
DATA_FORMAT_R32_SFLOAT for depth resolve on Forward+#113130Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
github-project-automation
bot
moved this to Unassessed
in 4.x Release Priorities & Blockers
Contributor
|
At least for my simple use of MSAA this restores it to working. |
akien-mga
moved this from Unassessed
to Immediate Blocker
in 4.x Release Priorities & Blockers
akien-mga
changed the title
DATA_FORMAT_R32_SFLOAT for depth resolve on Forward+
Contributor
|
Thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #78598 introduced the ability to resolve the depth buffer during subpasses however this required the use of a depth resolve buffer with the same format as is used for the MSAA version of the depth buffer.
On Forward+ we're not using the extension but handling resolve in shaders. This requires the
TEXTURE_USAGE_STORAGE_BITbit to be set, something not supported on the depth formats that include a stencil buffer.This PR changes the logic so if Forward+ is used, we use
DATA_FORMAT_R32_SFLOATas before.Fixed #113022