Merged
Conversation
Chaosus
approved these changes
Nov 22, 2025
Member
|
For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info. |
Contributor
Author
Thanks, I had managed to typo my email. |
Member
|
If you want to fix it for this commit, you can edit your Git identity locally, then amend the commit with |
aflorea-2k
force-pushed
the
fix-thread-warning
branch
from
630e682 to
35a6ba5
Compare
Contributor
Author
|
boom, fixed 😎 Thanks for the help ! |
AThousandShips
approved these changes
Nov 24, 2025
Contributor
|
Thanks! Congratulations on your first merged contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found what I believe to be a small error in the warning for calling a thread-unsafe function from a thread.
The function
call_thread_groupdoesn't exist. I believe it to be a typo from 98c655e, since it's the only commit that I've found that references this function.Instead, I believe the warning wanted to point to
call_deferred_thread_group. The commit mentionned above created this function.