OpenXR: Implement play_area_changed signal#113062
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 25, 2025
Merged
Conversation
This implements the missing logic for the 'play_area_changed' in OpenXRInterface. It modifies the existing 'on_reference_space_change_pending' method by receiving the XrReferenceSpaceType enum from the event and selects the appropriate PlayAreaMode, it finally emits the 'play_area_changed' signal.
m4gr3d
approved these changes
Nov 24, 2025
Contributor
|
Thanks! Congratulations on your first merged contribution! 🎉 |
Contributor
Author
|
Thank you very much! |
akien-mga
changed the title
play_area_changed signal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the missing logic for the 'play_area_changed' in OpenXRInterface as described in bug #112270.
It modifies the existing 'on_reference_space_change_pending' method by receiving the XrReferenceSpaceType enum from the event and selects the appropriate PlayAreaMode, it finally emits the 'play_area_changed' signal.