Fix assertions against buffer overruns in input_event_codec.cpp#113028
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 25, 2025
Merged
Conversation
Contributor
|
Thanks! Congratulations on your first merged contribution! 🎉 |
akien-mga
changed the title
input_event_codec.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed
DisplayServerEmbeddedState::serialize(in platform/macos/display_server_embedded.mm) had its assertion at the end fixed by @stuartcarnie fromDEV_ASSERT((data - r_data.ptrw()) >= r_data.size());to
DEV_ASSERT(r_data.size() >= (data - r_data.ptrw()));in commit c62ad8d
This makes sense, but I wanted to compare this change to similar asserts elsewhere.
Eventually this lead me to core/input/input_event_codec.cpp, which has a handful of equivalent assertions, also by @stuartcarnie.
It makes sense because we want to assert the buffer we are reading from / writing to is at least as long as the amount we have moved our
datapointer while decoding/encoding.This PR just follows his example and applies that fix to the
DEV_ASSERTs in input_event_codec.cpp as well.