X Tutup
Skip to content

Fix emulated touch events using the incorrect window ID#112995

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
zedzee37:touch_window_fix
Dec 9, 2025
Merged

Fix emulated touch events using the incorrect window ID#112995
akien-mga merged 1 commit intogodotengine:masterfrom
zedzee37:touch_window_fix

Conversation

@zedzee37
Copy link
Contributor

Fixes: #110200

@zedzee37 zedzee37 requested a review from a team as a code owner November 20, 2025 20:29
@AThousandShips AThousandShips added this to the 4.6 milestone Nov 21, 2025
@AThousandShips AThousandShips added the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Nov 21, 2025
Copy link
Member

@Alex2782 Alex2782 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, I searched the sources for InputEventScreenTouch and set_window_id is passed everywhere, it was just forgotten here. (MRP tested)

Copy link
Contributor

@Sauermann Sauermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. Didn't test though.

@akien-mga akien-mga merged commit 40c5b21 into godotengine:master Dec 9, 2025
20 checks passed
@akien-mga
Copy link
Member

Cherry-picked for 4.5.2.

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

emulate_touch_from_mouse doesn't work in sub-windows

5 participants

X Tutup