Prevent the main locale from being set to an empty string#112899
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 18, 2025
Merged
Prevent the main locale from being set to an empty string#112899Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
akien-mga
approved these changes
Nov 18, 2025
Mickeon
approved these changes
Nov 18, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's assumed that
TranslationServer.get_locale()always returns a non-empty string. But there is currently nothing to prevent it from being set to an empty string.Note: Technically, being non-empty is not enough for a string to be a valid locale. However, this appears to be the only requirement for locales in the current codebase.
Another reason for this change was that Akien encountered a case where
interface/editor/editor_languagesomehow carries an empty string, which caused an error spam when importing a 3D model. This issue cannot be reproduced consistently, but we should at least turn the error spam into only one error on startup.