OpenXR: Add profiling macro for process, xrWaitFrame() and acquiring swapchain#112893
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 18, 2025
Merged
OpenXR: Add profiling macro for process, xrWaitFrame() and acquiring swapchain#112893Repiteo merged 1 commit intogodotengine:masterfrom
xrWaitFrame() and acquiring swapchain#112893Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
Ivorforce
reviewed
Nov 17, 2025
Member
Ivorforce
left a comment
Ivorforce
left a comment
There was a problem hiding this comment.
Just some comments on the profiling style
dsnopek
force-pushed
the
openxr-profiling
branch
from
a6feb01 to
01a5ba4
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #104851, which actually already added profiling zones for some of the most interesting general XR areas, but it missed
XRServer::_process()So, this PR adds a profiling zone for
XRServer::_process(), as well as two OpenXR-specific operations (xrWaitFrame()and acquiring an OpenXR swapchain) which involve waiting and are important to keep an eye on (ie under normal operation they shouldn't take too long, but if things go wrong they could take a lot of time, and you'll want to know about it)Note: the diff around
xrWaitFrame()looks more complicated than it actually is, because it indents that code one more level