Implement XR_META_foveation_eye_tracked#112888
Conversation
There was a problem hiding this comment.
Thanks!
This is working great in my testing on a Samsung Galaxy XR. For the most part the XR code looks good to me, but I have one question below.
Regarding the use of VulkanHooks: @m4gr3d, @BastiaanOlij and I discussed this, and we can't think of another graphics API or platform aside from OpenXR that would need to use offsets for a VRS texture. So, in our opinion, using VulkanHooks is fine for now. It's also completely internal and so if another use case comes up, we can rework this without causing any compatibility issues for developers.
But I'm curious to hear what folks on the rendering team think!
(FYI, the code from the revert of dsnopek@820b5a5 was written by @DarioSamo - just to give proper credit :-))
|
Just to underline what David already said, I think this solution is sound for what we need. The VulkanHooks entry point is a bit iffy but as we don't know if any other graphics API will ever require this it's a solution with very little impact. |
dhoverb
force-pushed
the
meta_foveation_eye_tracked
branch
from
8013133 to
53e1ea1
Compare
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Thanks!
The XR changes look great to me! We still need feedback from the rendering team on the rendering changes
|
Thanks! |
|
It's turned out that this PR has caused regression on Meta Quest (and probably other) devices. I've created issue #112988 to track it |
akien-mga
changed the title
XR_META_foveation_eye_tracked
5 participants
In addition to integrating with XR_META_foveation_eye_tracked, this reverts dsnopek@820b5a5 since it provides the offsets to the fragment density map.
See more discussion here: #102780 (which has a link to https://github.com/dsnopek/godot/tree/pr/99551-no-offset)