X Tutup
Skip to content

Support reading available OpenXR runtimes from Windows registry#112884

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
ashwinvbs:master
Nov 26, 2025
Merged

Support reading available OpenXR runtimes from Windows registry#112884
akien-mga merged 1 commit intogodotengine:masterfrom
ashwinvbs:master

Conversation

@ashwinvbs
Copy link
Contributor

@ashwinvbs ashwinvbs requested a review from a team as a code owner November 17, 2025 18:12
@m4gr3d m4gr3d added this to the 4.6 milestone Nov 17, 2025
@m4gr3d
Copy link
Contributor

m4gr3d commented Nov 17, 2025

@ashwinvbs Can you address the CI failures.

@ashwinvbs ashwinvbs force-pushed the master branch 2 times, most recently from 4168227 to 21fabab Compare November 17, 2025 22:38
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I haven't tested, but the code looks good to me :-)

Copy link
Contributor

@devloglogan devloglogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected on Windows 11, default value for runtime paths was all the normal defaults plus it correctly detected Virtual Desktop.
Image

@akien-mga akien-mga merged commit 5603b3b into godotengine:master Nov 26, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

X Tutup