X Tutup
Skip to content

Fix not being able to set project path#112824

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
KoBeWi:connection_lost_(good)
Nov 17, 2025
Merged

Fix not being able to set project path#112824
Repiteo merged 1 commit intogodotengine:masterfrom
KoBeWi:connection_lost_(good)

Conversation

@KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Nov 15, 2025

Fixes #112811

@shitake2333 What was this connection for?

@KoBeWi KoBeWi added this to the 4.6 milestone Nov 15, 2025
@KoBeWi KoBeWi added the bug label Nov 15, 2025
@KoBeWi KoBeWi requested a review from a team November 15, 2025 19:22
@shitake2333
Copy link
Contributor

Sorry!
I misunderstood how EditorFileDialog works. I thought it used confirmation and cancellation.

This is indeed a perfectly correct fix! The only minor issue is that I previously misunderstood and used p_is_confirmed, which could potentially cause code robustness problems. It's best to rename it to p_is_canceled and reverse the corresponding logic to avoid misleading those reading the code later.

Again, I apologize for my carelessness and mistake!

https://github.com/godotengine/godot/blob/master/editor%2Fproject_manager%2Fproject_dialog.cpp#L834-L835

@Repiteo Repiteo merged commit 18c58df into godotengine:master Nov 17, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 17, 2025

Thanks!

@KoBeWi KoBeWi deleted the connection_lost_(good) branch November 17, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Selecting project path does not working correctly

4 participants

X Tutup