Reorganize canvas shader varyings in RD renderer#112800
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 17, 2025
Merged
Reorganize canvas shader varyings in RD renderer#112800Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
stuartcarnie
approved these changes
Nov 15, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #112799
Regression from #112481
The simple fix was to increase the value of
actions.base_varying_indexto1 +whatever the highest varying index is in the shader. However, in doing so, I set it to 10, which struck me as way too high. We should not be using up ten varying slots in our internal shader. Some hardware is limited to 16 total, so us reserving 10 for our own use is a bit extreme.I took a look at our current varying usage and was able to clean it up a bit and free up two extra slots. With more extreme optimizations, we could potentially free up 1-2 more as well. But I figured this was enough for now.
In addition to freeing up more varying slots for our users, this PR also may improve performance on some Adreno devices