Merged
Conversation
Ivorforce
approved these changes
Nov 15, 2025
Member
Ivorforce
left a comment
Ivorforce
left a comment
There was a problem hiding this comment.
Assessment is correct, keeping these files around doesn't do anything.
Mickeon
approved these changes
Nov 16, 2025
Member
Mickeon
left a comment
Mickeon
left a comment
There was a problem hiding this comment.
"+1 -72" commits are so satisfying
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#108862 moved the capabilities of
TranslationPOintoTranslation, making it an empty class.Its files were kept because I was thinking about being compatible with cases where the user saved the loaded
.pofile (aTranslationPOinstance) as a new resource file (e.g.,.tres) in the old version and wants to open it in the new version.@KoBeWi pointed out that the class was never exposed, so that kind of resource files can't be loaded successfully in the old version anyway. So there is actually nothing to be compatible with 🤣