Fix TileMapLayer transformations for Node2D scene tiles#112790
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 18, 2025
Merged
Fix TileMapLayer transformations for Node2D scene tiles#112790Repiteo merged 1 commit intogodotengine:masterfrom
TileMapLayer transformations for Node2D scene tiles#112790Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
kleonc
force-pushed
the
tile_map_layer_fix_scene_tile_transformations
branch
from
367d388 to
944bd82
Compare
groud
approved these changes
Nov 15, 2025
Member
groud
left a comment
groud
left a comment
There was a problem hiding this comment.
Ah damned, I approved the other PR a bit fast.
That's a good fix, thanks!
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed #108010 got merged, but it's completely broken as #108010 (comment) was never addressed, the scale is still being added. 🙃
While at it I've changed it to:
Note that currently placing a scene tile with non-default transform flags will throw an error, as tranforms flags are not ignored from the id here:
godot/scene/resources/2d/tile_set.cpp
Lines 5852 to 5855 in ef34c3d
But seems it needs to be handled properly in few other places as well. Leaving it for another PR, should be probably resolved at once with #112175.