Open missing source file errors on GitHub#112759
Open
KoBeWi wants to merge 1 commit intogodotengine:masterfrom
Open
Open missing source file errors on GitHub#112759KoBeWi wants to merge 1 commit intogodotengine:masterfrom
KoBeWi wants to merge 1 commit intogodotengine:masterfrom
Conversation
Calinou
reviewed
Nov 18, 2025
KoBeWi
force-pushed
the
GitHubization_of_the_editor
branch
from
a9a9bb3 to
4fb64a4
Compare
Calinou
requested changes
Nov 18, 2025
Member
There was a problem hiding this comment.
Tested locally, it doesn't seem to work on my end:
- If I keep the compiled binary in the source repository, it will open the source file in the external editor as intended.
- If I move the compiled binary out of the source repository, it will create a new file named after the last component of the path in the external editor (e.g.
variant_utility.cppfor an error in./core/variant/variant_utility.cpp:1024).
This presumably occurs because the path.begins_with("./") check applies even if the file doesn't exist.
Tested using this code (save it and use Scene > Reload Saved Scene, or restart the editor):
@tool
extends Node
func _ready() -> void:
push_error("test")
Member
Author
|
Should be fixed now. |
akien-mga
reviewed
Dec 19, 2025
akien-mga
reviewed
Dec 19, 2025
KoBeWi
force-pushed
the
GitHubization_of_the_editor
branch
from
4fb64a4 to
6d74b99
Compare
KoBeWi
force-pushed
the
GitHubization_of_the_editor
branch
from
6d74b99 to
a1a6aae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #111805
That PR didn't properly handle missing files. This PR makes the editor try to open them on GitHub.
It would be helpful if official builds came with some prefix for source paths, it would be easier to differentiate them from actually missing files in custom builds. The way I did it might be unreliable and try to open non-existent files.