Revert "Add "Show in File Manager" button to sidebar of Project Manager"#112730
Closed
Ivorforce wants to merge 1 commit intogodotengine:masterfrom
Closed
Revert "Add "Show in File Manager" button to sidebar of Project Manager"#112730Ivorforce wants to merge 1 commit intogodotengine:masterfrom
Ivorforce wants to merge 1 commit intogodotengine:masterfrom
Conversation
This reverts commit 769007c.
Contributor
akien-mga
approved these changes
Nov 13, 2025
Member
|
I opened #112733 |
Contributor
|
I think reverting this before #112733 is preferable, as that more clearly conveys the intent |
Member
|
Then my PR will have to add the same code again. |
Member
Author
|
It's not a lot of code, so I don't think it's a problem. Regarding ownership, you could add Meorge as a co-author on your commit message. |
Contributor
|
Failing that, #112733 could have a second commit which simply removes the button. I'd accept that in this PR's stead, as it ultimately accomplishes the same goal |
Contributor
|
Superseded by #112733 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 769007c (#111624).
It was noted that the new button is larger than the others, creating a UX issue in some languages, especially those where the translated button title is long.
My proposal to revert this PR was mostly well received.
I recommend adding a right-click menu to the project manager, and adding this item there instead.
Merging this may supersede #112717.(see arkology's comment below)