Add some comments in the profiling.h header.#112725
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 14, 2025
Merged
Add some comments in the profiling.h header.#112725Repiteo merged 1 commit intogodotengine:masterfrom
profiling.h header.#112725Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
AThousandShips
approved these changes
Nov 13, 2025
Member
AThousandShips
left a comment
AThousandShips
left a comment
There was a problem hiding this comment.
Approving on form, and the text makes sense
Repiteo
approved these changes
Nov 14, 2025
Contributor
Repiteo
left a comment
Repiteo
left a comment
There was a problem hiding this comment.
Simple docstring changes, won't need any lengthy approval process
Contributor
|
Thanks! |
akien-mga
changed the title
profiling.h header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the profiling arguments will be documented on the docs, I don't expect we'll be documenting the exact implementation of the macros there. Most people will probably use the hooks we build in, and won't need to add their own.
Besides, the implementation is (currently) quite simple, so I think it is sufficient to comment the macros, rather than have a new article explaining how it works.