X Tutup
Skip to content

Fix ProjectManager UI going below window#112717

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
arkology:project-manager-ui-height
Jan 1, 2026
Merged

Fix ProjectManager UI going below window#112717
akien-mga merged 1 commit intogodotengine:masterfrom
arkology:project-manager-ui-height

Conversation

@arkology
Copy link
Contributor

@arkology arkology commented Nov 13, 2025 •
edited
Loading

Before-after:

513777477-805db3b0-0493-4141-95fc-e66a6acdf90a

To see this bug, minimize ProjectManager window and set Display Scale to the lowest possible value. Bottom line with version info will go out of window.

@arkology arkology requested a review from a team November 13, 2025 09:08
@arkology
Copy link
Contributor Author

arkology commented Nov 13, 2025

This overflow is caused by amount of buttons on right side of ProjectManager.
Taking this info into account, this is regression from:

@AThousandShips AThousandShips added this to the 4.6 milestone Nov 13, 2025
@arkology arkology mentioned this pull request Nov 13, 2025
Merged
@coppolaemilio
Copy link
Member

coppolaemilio commented Nov 13, 2025

We still need to revert the change of adding the "show in file manager" button, so there should be one button less in the final version.

@arkology
Copy link
Contributor Author

arkology commented Nov 13, 2025

Thanks for info. I found what are you talking about - #111624 (comment).

Anyway in future new buttons could be added and this will lead to the same problem, so I think it's worth to fix it.
Yes, after reverting #111624 this PR will have only potential usefulness,
However, right now this PR is fixing a problem that actually exists at the moment.

@Ivorforce Ivorforce mentioned this pull request Nov 13, 2025
Closed
@Repiteo Repiteo requested a review from KoBeWi November 13, 2025 23:45
@Repiteo Repiteo modified the milestones: 4.6, 4.x Nov 19, 2025
@Calinou
Copy link
Member

Calinou commented Dec 1, 2025

@arkology Can you rebase this PR if you have time? I'd like to test and review it.

@arkology
Copy link
Contributor Author

arkology commented Dec 1, 2025

Sure!

@arkology arkology force-pushed the project-manager-ui-height branch from 0d64c4a to ef07428 Compare December 1, 2025 18:43
KoBeWi
KoBeWi approved these changes Dec 30, 2025
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really reproduce the bug, but the code seems fine.

@KoBeWi KoBeWi modified the milestones: 4.x, 4.6 Dec 30, 2025
@akien-mga akien-mga merged commit 779fd0a into godotengine:master Jan 1, 2026
20 checks passed
@akien-mga
Copy link
Member

akien-mga commented Jan 1, 2026

Thanks!

@arkology arkology deleted the project-manager-ui-height branch January 1, 2026 19:23
@akien-mga akien-mga added the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 16, 2026
@akien-mga
Copy link
Member

akien-mga commented Jan 16, 2026

Cherry-picked for 4.5.2.

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees

No one assigned

Labels

bug topic:editor

Projects

None yet

Milestone

4.6

Development

Successfully merging this pull request may close these issues.

7 participants

@arkology @coppolaemilio @Calinou @akien-mga @KoBeWi @Repiteo @AThousandShips
X Tutup