X Tutup
Skip to content

Add memory profiling macros for tracy profiler option#112702

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
enetheru:tracy-mem
Nov 17, 2025
Merged

Add memory profiling macros for tracy profiler option#112702
Repiteo merged 1 commit intogodotengine:masterfrom
enetheru:tracy-mem

Conversation

@enetheru
Copy link
Contributor

Now that #104851 is merged.
Here is memory tracing macros and their usage for tracy profiler.

Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a straight-forward improvement!

Do you happen to know if this has any effects on performance?
If so, it might make sense to only enable memory tracking with a profiler option. I didn't find any information about this in the tracy manual. I guess by the rest of tracy's implementation, we don't need to worry about any performance penalties?

@enetheru
Copy link
Contributor Author

I would have to profile the profiler ;)
I like options, but perhaps it can wait till there is noticable reason. I certainly havent noticed in my rudimentary testing.

Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I think this is very useful information to have for profiling.

@Ivorforce Ivorforce modified the milestones: 4.x, 4.6 Nov 13, 2025
@stuartcarnie
Copy link
Contributor

Can confirm it works for me using Tracy. Nice work!

Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a squash before it can be merged.

Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some clarity changes

Co-authored-by: Lukas Tenbrink <lukas.tenbrink@gmail.com>
@Repiteo Repiteo merged commit f4bb9ea into godotengine:master Nov 17, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 17, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup