Fix blurry items on PopupMenu when v_separation has an odd value#112676
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 14, 2025
Merged
Conversation
Contributor
|
Good point. It offsets the icon to the nearest pixel. The modern theme definition itself should also be reviewed, as there is a good number of non-integer multiplications of EDSCALE that are not rounded/floored afterwards. Otherwise there will remain a slight decentering of the contents of some items. Perhaps for another fix! |
bruvzg
reviewed
Nov 13, 2025
YeldhamDev
force-pushed
the
why_were_those_floats_in_the_first_place
branch
from
47a2ea8 to
41d93ca
Compare
bruvzg
approved these changes
Nov 13, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112557.