X Tutup
Skip to content

Fix visual shader error when editing theme settings#112673

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
YeldhamDev:vs_theme_error_fix
Nov 18, 2025
Merged

Fix visual shader error when editing theme settings#112673
Repiteo merged 1 commit intogodotengine:masterfrom
YeldhamDev:vs_theme_error_fix

Conversation

@YeldhamDev
Copy link
Member

This fixes an error that can happen when opening the editor with a node selected that has a visual shader, and then changing some theme setting:

ERROR: Attempt to disconnect a nonexistent connection from '0:<VSGraphNode#2176474766612>'. Signal: 'item_rect_changed', callable: 'CanvasItem::queue_redraw'.

This change shouldn't reintroduce #96289, since connections_layer is set to nullptr if removed anyways.

@YeldhamDev YeldhamDev added this to the 4.6 milestone Nov 12, 2025
@YeldhamDev YeldhamDev requested a review from a team as a code owner November 12, 2025 14:43
@Geometror Geometror self-assigned this Nov 15, 2025
@Repiteo Repiteo merged commit 34e5b4e into godotengine:master Nov 18, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 18, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup