Improve language selection when shaping text.#112661
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Dec 18, 2025
Merged
Improve language selection when shaping text.#112661akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
bruvzg
commented
Nov 12, 2025
| { "chy", "Cheyenne" }, | ||
| { "cic", "Chickasaw" }, | ||
| { "ckb", "Central Kurdish" }, | ||
| { "csb", "Kashubian" }, |
Member
Author
There was a problem hiding this comment.
Note: these were duplicate lines.
bruvzg
commented
Nov 12, 2025
Comment on lines
-706
to
-707
| const String *language; | ||
| const String *script_code; |
Member
Author
There was a problem hiding this comment.
Note: original strings can get out of scope, so pointer won't work. This might be an issue without this PR as well.
bruvzg
force-pushed
the
lang_shape
branch
2 times, most recently
from
da55469 to
caa520c
Compare
AThousandShips
changed the title
akien-mga
approved these changes
Dec 18, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112423