Avoid extra copy in Vector/CowData push_back/insert#112630
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 11, 2025
Merged
Avoid extra copy in Vector/CowData push_back/insert#112630Repiteo merged 1 commit intogodotengine:masterfrom
Vector/CowData push_back/insert#112630Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
Ivorforce
reviewed
Nov 11, 2025
Member
There was a problem hiding this comment.
I've been unhappy with this section for a while, partially due to the requirement of needing to solve the "copy from inside to inside" problem (#31736).
Anyway, this is a safe improvement, so I definitely think we should merge it!
However, there are a few other spots where we're making explicit copies. Please address those as well. They can be identified by the GH-31736 comment.
c925b21 to
0afc133
Compare
Vector/CowData push_backVector/CowData push_back/insert
Contributor
Author
|
Updated with a similar change for |
Update push_back/insert methods to move new item into CowData instead of copying
0afc133 to
afd59b3
Compare
Ivorforce
approved these changes
Nov 11, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
push_back/insertmethods to move new item intoCowDatainstead of copying.This mainly helps with
String/RefCountedtypes, makingArray.push_backaround 20% faster for these types, and similar improvement forString.split, compared with gdscript below:old:
new: