PopupMenu: Add theme option for merging icon and checkbox gutters#112545
PopupMenu: Add theme option for merging icon and checkbox gutters#112545Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
|
Oh goodness me, thank you. This has been bothering me for so long. It's egregiously bad in a node's right-click menu, too. |
Mickeon
left a comment
Mickeon
left a comment
There was a problem hiding this comment.
This makes me greatly question when is it ever a bad idea to make icons and checkboxes compact whenever possible. I genuinely can't think of a reason not to.
timothyqiu
force-pushed
the
compact-menu-gutter
branch
from
aad67ad to
4694ee8
Compare
I don't believe there's an absolute right or wrong here. Different projects can have different design conventions. For example, this KCalc menu separates icons and checkboxes: 
|
|
Alright, but forgive me if I'm wrong: Wouldn't it also be possible to replicate KCalc's and the current behavior by assigning a texture to any checkbox option, even a dummy texture? The theme item is good, I suppose, but the workaround is totally possible if absolutely desired. |
Yes, it works. It's mainly a matter of proper support vs. hack-your-own-way-through :P |
Mickeon
left a comment
Mickeon
left a comment
There was a problem hiding this comment.
Docs okay. Not sure about implementation.
bruvzg
left a comment
bruvzg
left a comment
There was a problem hiding this comment.
Code looks good, seems to be working as expected.
For the reference, macOS menus usually use two columns for icon and checkmark as well (but indent for different items can change), but at least in context of Godot editor it makes sense to use compact mode: 
|
|
Thanks! |
5 participants
Closes #37178
Closes #109578
This PR adds a
gutter_compacttheme constant which acts as a boolean. If true, the icon gutter will be merged with the checkbox gutter when possible (the exception is when there is a menu item that has both an icon and a checkbox).The default theme sets this constant to
1. It's an option as there are different established styles in the wild, see examples in the linked issues.