[D3D12] Fall back to HWND if DComp init failed.#112497
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 7, 2025
Merged
[D3D12] Fall back to HWND if DComp init failed.#112497Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
blueskythlikesclouds
approved these changes
Nov 7, 2025
Contributor
blueskythlikesclouds
left a comment
blueskythlikesclouds
left a comment
There was a problem hiding this comment.
I was going to mention that WS_EX_NOREDIRECTIONBITMAP should be removed when this fails, but it's practically impossible for this function to fail on Windows, and Wine doesn't seem to care about the flag in any capacity, so it should be fine.
AThousandShips
changed the title
Contributor
|
Thanks! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #112344 which accidentally fixed D3D12 renderer on Wine (for apps w/o transparency).
Adds fallback in case
CreateSwapChainForCompositionis not supported, to ensure apps with enabled transparency will run on Wine as well.See https://chat.godotengine.org/channel/platforms?msg=mdudSWFLtEYZe9Swg