Fix glow visual compatibility regression#112471
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 10, 2025
Merged
Conversation
AThousandShips
changed the title
clayjohn
requested changes
Nov 6, 2025
Member
clayjohn
left a comment
clayjohn
left a comment
There was a problem hiding this comment.
You need to change the default value everywhere, not just in Environment.h
Is one place:
You should look at the original PR to find the other places where it needs to be changed.
After that, you need to run doctool to update the documentation. How to do that is described here: https://contributing.godotengine.org/en/latest/documentation/class_reference.html#updating-class-reference-when-working-on-the-engine
Reverts the default value of Environment.glow_hdr_threshold from 0.0 back to 1.0 to restore the expected glow appearance in existing projects. The default was inadvertently changed from 1.0 to 0.0 in PR godotengine#110077, which caused glow effects to render dramatically different across all rendering methods (Forward+, Mobile, and GL Compatibility). This broke backward compatibility with existing projects like the Kenney 3D Platformer starter kit. Changed files: - scene/resources/environment.h - servers/rendering/storage/environment_storage.h - drivers/gles3/effects/glow.h - drivers/gles3/rasterizer_scene_gles3.cpp - doc/classes/Environment.xml Setting the value back to 1.0 aligns with documented recommendations and restores visual consistency. Fixes godotengine#112469
Rudra-ravi
force-pushed
the
claude/fix-godot-official-issues-011CUrnHud9iQ4LV6FDv2hG7
branch
from
e6f5b71 to
802eb0b
Compare
clayjohn
approved these changes
Nov 10, 2025
Member
clayjohn
left a comment
clayjohn
left a comment
There was a problem hiding this comment.
Looks fine to me. Thanks for making the requested changes!
Contributor
|
Thanks! Congratulations on your first merged contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the default value of Environment.glow_hdr_threshold from 0.0 back to 1.0 to restore the expected glow appearance in existing projects.
The default was inadvertently changed from 1.0 to 0.0 in PR #110077, which caused glow effects to render dramatically different across all rendering methods (Forward+, Mobile, and GL Compatibility). This broke backward compatibility with existing projects like the Kenney 3D Platformer starter kit.
Setting the value back to 1.0 aligns with documented recommendations and restores visual consistency.
Fixes #112469